pom.xml review request

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

pom.xml review request

Cheng Fang-2
I'd like to move annotation handlers and related classes from
ejb-container module to ejb-connector module.  Below the the changes to
pom.xml in these 2modules.  Can someone review it?  This change is in
trunk.  A similar change is already in 3.1.2 branch.  Thanks.

Index: ejb-connector/pom.xml
===================================================================
--- ejb-connector/pom.xml       (revision 48929)
+++ ejb-connector/pom.xml       (working copy)
@@ -83,6 +83,11 @@
<version>${project.version}</version>
</dependency>
<dependency>
+ <groupId>org.glassfish.deployment</groupId>
+ <artifactId>dol</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
<groupId>org.glassfish.hk2</groupId>
<artifactId>hk2</artifactId>
</dependency>
Index: ejb-container/pom.xml
===================================================================
--- ejb-container/pom.xml       (revision 48929)
+++ ejb-container/pom.xml       (working copy)
@@ -239,6 +239,11 @@
<version>${project.version}</version>
</dependency>
<dependency>
+ <groupId>org.glassfish.ejb</groupId>
+ <artifactId>gf-ejb-connector</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
<groupId>org.glassfish.hk2.external</groupId>
<artifactId>asm-all-repackaged</artifactId>
<version>${hk2.version}</version>

Reply | Threaded
Open this post in threaded view
|

Re: pom.xml review request

Jane Young
Looks fine.  Thanks.

On 8/19/11 1:12 PM, Cheng Fang wrote:

> I'd like to move annotation handlers and related classes from
> ejb-container module to ejb-connector module.  Below the the changes
> to pom.xml in these 2modules.  Can someone review it?  This change is
> in trunk.  A similar change is already in 3.1.2 branch.  Thanks.
>
> Index: ejb-connector/pom.xml
> ===================================================================
> --- ejb-connector/pom.xml       (revision 48929)
> +++ ejb-connector/pom.xml       (working copy)
> @@ -83,6 +83,11 @@
> <version>${project.version}</version>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.deployment</groupId>
> + <artifactId>dol</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> <groupId>org.glassfish.hk2</groupId>
> <artifactId>hk2</artifactId>
> </dependency>
> Index: ejb-container/pom.xml
> ===================================================================
> --- ejb-container/pom.xml       (revision 48929)
> +++ ejb-container/pom.xml       (working copy)
> @@ -239,6 +239,11 @@
> <version>${project.version}</version>
> </dependency>
> <dependency>
> + <groupId>org.glassfish.ejb</groupId>
> + <artifactId>gf-ejb-connector</artifactId>
> + <version>${project.version}</version>
> + </dependency>
> + <dependency>
> <groupId>org.glassfish.hk2.external</groupId>
> <artifactId>asm-all-repackaged</artifactId>
> <version>${hk2.version}</version>
>