review fix issue 17988 move ejb annotation handlers out of ejb-connector

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

review fix issue 17988 move ejb annotation handlers out of ejb-connector

Cheng Fang-2

Please review the fix for issue
http://java.net/jira/browse/GLASSFISH-17988, in trunk only.

Issue 17988 Move ejb-related annotation handler classes from
ejb-connector to ejb-container (opposite of r48934) now that handlers
are dynamically loaded with @AnnotationHandlerFor.
Move Import-Package: org.glassfish.apf.context entry from
ejb-connector/osgi.bundle to ejb-container/osgi.bundle for AIX (see
issue 10545)

The changes to pom.xml and osgi.bundle files are are the top of diff,
followed by moved content.

Thanks!

-cheng

diff.diff (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: review fix issue 17988 move ejb annotation handlers out of ejb-connector

Sahoo
Hi Cheng,

The changes look mostly good. I have one small comment. I don't think we
should be moving EjbAnnotationTypesProvider, EjbInWarArchivist and
EjbInWarScanner as part of this task. They seem unrelated to the current
task. It will be good to know why they are placed in the
gf-ejb-connector module and create a separate task to move them out. I
hope you agree with me. I am assuming we can move the ejb annotation
handlers without having to move these three classes.

Thanks,
Sahoo


On Friday 16 December 2011 04:37 AM, Cheng Fang wrote:

>
> Please review the fix for issue
> http://java.net/jira/browse/GLASSFISH-17988, in trunk only.
>
> Issue 17988 Move ejb-related annotation handler classes from
> ejb-connector to ejb-container (opposite of r48934) now that handlers
> are dynamically loaded with @AnnotationHandlerFor.
> Move Import-Package: org.glassfish.apf.context entry from
> ejb-connector/osgi.bundle to ejb-container/osgi.bundle for AIX (see
> issue 10545)
>
> The changes to pom.xml and osgi.bundle files are are the top of diff,
> followed by moved content.
>
> Thanks!
>
> -cheng